[RF] Support analytical integration of RooStepFunction #17593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like with other wrapper classes like RooExtendPdf, we can safely use the analytical integration capabilities of the wrapped object, becuase we don't do any no-linear transformation.
Implement analytical integration capability for RooStepFunction, because this class is the easiest way to implement a bounded uniform distribution without adding serialized class members to the RooUniform (see root-project#7880). Add a unit test that verifies that wrapping a `RooStepFunction` in a `RooWrapperPdf` doesn't result in any numerical integrals.
Test Results 18 files 18 suites 4d 10h 8m 56s ⏱️ For more details on these failures, see this check. Results for commit f2da82c. |
dpiparo
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement analytical integration capability for RooStepFunction, because
this class is the easiest way to implement a bounded uniform
distribution without adding serialized class members to the RooUniform
(see #7880).
Add a unit test that verifies that wrapping a
RooStepFunctionin aRooWrapperPdfdoesn't result in any numerical integrals.Closes #7880.